Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use WordPress site name instead hardcoded name #539

Merged
merged 1 commit into from
Jul 4, 2023
Merged

use WordPress site name instead hardcoded name #539

merged 1 commit into from
Jul 4, 2023

Conversation

riccardodicurti
Copy link
Contributor

Description of the Change

This PR is a proposal. It would be nice if instead of "Brand Logo" the initial demo loaded the site name taken from WordPress using useAppSettings.

NOTE:

Creating the commit I have this error that I could not solve from the eslint configuration, so I disabled temporarily husky for this commit. error Unable to resolve path to module '@headstartwp/next' import/no-unresolved

Closes #

How to test the Change

Changelog Entry

Added - New feature

  • use WordPress site name instead hardcoded name

Credits

Props @riccardodicurti

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@changeset-bot
Copy link

changeset-bot bot commented Jul 1, 2023

⚠️ No Changeset found

Latest commit: 51038e0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jul 1, 2023

Someone is attempting to deploy a commit to the tenup-internal Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Jul 4, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
headstarwp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 4, 2023 2:21pm

@nicholasio
Copy link
Member

Thanks for your PR!

[skipping changelog since this only changes the starter project).

@nicholasio nicholasio merged commit 43e6dc5 into 10up:develop Jul 4, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicholasio nicholasio nicholasio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@riccardodicurti @nicholasio @riccardodicurtimk